Skip to content

Commit

Permalink
test(bigquery): fix array concat test (#10584)
Browse files Browse the repository at this point in the history
Fixes the upstream failing test cases for bigquery.
  • Loading branch information
cpcloud authored Dec 16, 2024
1 parent 35f2b9d commit e54b306
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion ibis/backends/tests/test_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,13 @@ def test_array_concat_scalar(con, op):
reason="doesn't support nullable arrays",
)
@pytest.mark.notyet(
["bigquery"], raises=AssertionError, reason="bigquery treats null arrays as empty"
["bigquery"],
raises=ValueError,
reason=(
"bigquery treats null arrays as empty "
"and a ValueError is raised from `pd.isna` "
"when the value is not a truthy value"
),
)
def test_array_concat_with_null(con, op):
non_null_value = ibis.array([2**31 - 1])
Expand Down

0 comments on commit e54b306

Please sign in to comment.