-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datafusion): add map methods to datafusion compiler #10510
base: main
Are you sure you want to change the base?
Conversation
Very nice! Thank you for working on this, @venkat-oss. Could you remove the "notyet" markers in the tests so that we can ensure these operations run properly with DataFusion? Here is an example of a marker and where they can be found in the case of the tests for map: ibis/ibis/backends/tests/test_map.py Lines 657 to 660 in db8af10
After this, can you run your code through the linter? If you have ruff format .
ruff check --fix . |
@venkat-oss Any chance you can continue work on this PR? It looks like there are a sizable number of map-type test failures related to your new implementations. Let us know if you need some assistance. |
Will try to get this over the finish line soon @cpcloud 👍🏼 |
ops.Map - ✅ (Already supported by ibis)
ops.MapLength - ✅
ops.MapGet - ✅
ops.MapContains - ✅
ops.MapKeys - ✅
ops.MapValues - ✅
ops.MapMerge - 🆘 Need help