refactor(api): remove IntegerValue.label
#10595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
cpcloud
force-pushed
the
remove-labels-method
branch
from
0e1d154 to
bc7acbd
Compare
gforsyth
approved these changes
Dec 18, 2024
|
+1 to including a guide/example on how to migrate in the commit message, which can then get included in the changelog when that gets authored. I would also not categorize this as a refactor(API) commit if there is a tag for breaking(API) or something. Or we should add one. refactor as a tag is definitely misleading. Besides those two things looks great! Thanks. |
NickCrews
approved these changes
Dec 19, 2024
|
The category of the change and whether it's breaking are two mostly independent properties. |
cpcloud
force-pushed
the
remove-labels-method
branch
from
bc7acbd to
5d10a82
Compare
BREAKING CHANGE: `IntegerValue.label` is redundant with the `IntegerValue.cases` method, use that instead. Replace `expr.label(labels)` with `expr.cases(*enumerate(labels))`
cpcloud
force-pushed
the
remove-labels-method
branch
from
5d10a82 to
90391a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9612.
BREAKING CHANGE:
IntegerValue.labelis redundant with theIntegerValue.casesmethod, use that instead. Replaceexpr.label(labels)withexpr.cases(*enumerate(labels))