Skip to content

fix(duckdb): do not replace an existing table or view in read_* methods - #12154

Closed
nil68657 wants to merge 1 commit into
ibis-project:mainfrom
nil68657:fix-duckdb-read-no-replace
Closed

nil68657 wants to merge 1 commit into
ibis-project:mainfrom
nil68657:fix-duckdb-read-no-replace

Conversation

@nil68657

Copy link
Copy Markdown

Description of changes

read_parquet, read_csv and the other readers created their view with
CREATE OR REPLACE, so reading into a name that was already in use
silently swapped the definition under existing expressions. Create the
view without OR REPLACE, as read_geo already does, so DuckDB raises
instead.

Issues closed

This PR is a joint contribution from Nilanjan Chatterjee and Claude (Claude Opus 5.5, via Claude Code). Nilanjan chose the issue and directed the work; Claude reproduced the problem, wrote the change, its tests and this description.

Authored by Nilanjan Chatterjee (@nil68657).

read_parquet, read_csv and the other readers created their view with
CREATE OR REPLACE, so reading into a name that was already in use
silently swapped the definition under existing expressions. Create the
view without OR REPLACE, as read_geo already does, so DuckDB raises
instead.

Fixes ibis-project#9199

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added tests Issues or PRs related to tests duckdb The DuckDB backend labels Oct 11, 2026
@deepyaman deepyaman added the maybe-ai Apply to low-effort autonomous PRs to automatically close them. label Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This was marked as potentially AI generated and will be closed now. If this is an error, please provide additional details, make sure to read the docs about contributing and AI.

@github-actions github-actions Bot closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duckdb The DuckDB backend maybe-ai Apply to low-effort autonomous PRs to automatically close them. tests Issues or PRs related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: read_parquet and similar methods silently overwrite tables

2 participants