Repository navigation
Conversation
read_parquet, read_csv and the other readers created their view with CREATE OR REPLACE, so reading into a name that was already in use silently swapped the definition under existing expressions. Create the view without OR REPLACE, as read_geo already does, so DuckDB raises instead. Fixes ibis-project#9199 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This was marked as potentially AI generated and will be closed now. If this is an error, please provide additional details, make sure to read the docs about contributing and AI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
read_parquet, read_csv and the other readers created their view with
CREATE OR REPLACE, so reading into a name that was already in use
silently swapped the definition under existing expressions. Create the
view without OR REPLACE, as read_geo already does, so DuckDB raises
instead.
Issues closed
read_parquetand similar methods silently overwrite tables #9199This PR is a joint contribution from Nilanjan Chatterjee and Claude (Claude Opus 5.5, via Claude Code). Nilanjan chose the issue and directed the work; Claude reproduced the problem, wrote the change, its tests and this description.
Authored by Nilanjan Chatterjee (@nil68657).