-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move tpc-h testing setup into ibis #7190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
tpch-tests
branch
7 times, most recently
from
September 26, 2023 09:21
c324e8d
to
710a8a8
Compare
cpcloud
force-pushed
the
tpch-tests
branch
3 times, most recently
from
September 26, 2023 12:06
d5a29be
to
7e0e43f
Compare
Backend tests are passing:
|
gforsyth
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our TPC-H testing into ibis.
Up to now, we've been doing tests with https://github.com/ibis-project/tpc-queries, which was usually fine.
However, during some development of #6996 the
tpc-queries
job started failingand I moved TPC-H into ibis for faster debugging cycles.
This PR is the result of that work.
It turns out that for the other backend I added here (Snowflake) we're failing
three tpc-h tests that involve correlated subqueries (surprise!).
We can incrementally add support for more backends by:
Setting the appropriate
supports_tpch
flag in the backend'sTestConf
class.Defining a few methods on the backend's
TestConf
class: