Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullsoft Installer script for Win32 #54

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

bkpsu
Copy link

@bkpsu bkpsu commented Apr 1, 2012

I put together a quick installer script for KeyFinder, which will create a binary install package (easier to deal with than a zip archive).

One thing to do possibly, is make the version # (line 13 in the script) variable, based off some variable (like VERSION.h or a system environment variable).

@ibsh
Copy link
Owner

ibsh commented Apr 2, 2012

Very cool. Does it run the vcredist if necessary?
And yeah, making the version number variable would be preferable.

@bkpsu
Copy link
Author

bkpsu commented Apr 2, 2012

Vcredist is run in passive mode, but if it already exists, it can be
cancelled..ill work on making version number variable..
On Apr 2, 2012 4:22 AM, "Ibrahim Sha'ath" <
[email protected]>
wrote:

Very cool. Does it run the vcredist if necessary?
And yeah, making the version number variable would be preferable.


Reply to this email directly or view it on GitHub:
#54 (comment)

@bkpsu
Copy link
Author

bkpsu commented Apr 3, 2012

Version.txt stores the version as a variable, keeping the .nsi script stable between builds. Could be possible to auto-gen the text file as part of your build process. There is another way, which pulls the version # out of the KeyFinder.exe file automagically to use in the installer, but currently the .exe file doesn't have version info stored in it.

@ibsh
Copy link
Owner

ibsh commented Apr 3, 2012

OK, I think the version in the executable comes from the .rc file in Qt. I'll take a look at that at some point. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants