Skip to content

Commit

Permalink
Merge pull request #39 from icd2k3/fix-key-warning-for-optional-params
Browse files Browse the repository at this point in the history
Fixes issue with duplicate key warning if using optional params
  • Loading branch information
icd2k3 authored Jun 16, 2018
2 parents df8c9cc + 877ed63 commit 9acb124
Show file tree
Hide file tree
Showing 4 changed files with 235 additions and 208 deletions.
22 changes: 11 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-router-breadcrumbs-hoc",
"version": "2.1.3",
"version": "2.1.4",
"description": "Just a tiny, flexible, higher order component for rendering breadcrumbs with react-router 4.x",
"repository": "icd2k3/react-router-breadcrumbs-hoc",
"keywords": [
Expand All @@ -23,8 +23,8 @@
"humanize-string": "^1.0.2"
},
"devDependencies": {
"@types/react": "^16.3.14",
"@types/react-router-dom": "^4.2.6",
"@types/react": "^16.3.18",
"@types/react-router-dom": "^4.2.7",
"babel-cli": "^6.26.0",
"babel-core": "^6.26.3",
"babel-eslint": "^8.2.3",
Expand All @@ -41,18 +41,18 @@
"eslint-config-airbnb": "^16.1.0",
"eslint-plugin-import": "^2.12.0",
"eslint-plugin-jsx-a11y": "^6.0.3",
"eslint-plugin-react": "^7.8.2",
"jest": "^23.0.1",
"eslint-plugin-react": "^7.9.1",
"jest": "^23.1.0",
"prop-types": "^15.6.1",
"react": "^16.4.0",
"react-dom": "^16.4.0",
"react-router": "^4.2.0",
"react-router-dom": "^4.2.2",
"rollup": "^0.59.4",
"react": "^16.4.1",
"react-dom": "^16.4.1",
"react-router": "^4.3.1",
"react-router-dom": "^4.3.1",
"rollup": "^0.60.7",
"rollup-plugin-babel": "^3.0.4",
"rollup-plugin-commonjs": "^9.1.3",
"rollup-plugin-node-resolve": "^3.3.0",
"typescript": "^2.8.3"
"typescript": "^2.9.2"
},
"scripts": {
"prepublishOnly": "npm run build",
Expand Down
1 change: 0 additions & 1 deletion rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const globals = {

const config = {
input: 'src/index.js',
exports: 'named',
plugins: [
babel({
exclude: 'node_modules/**',
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const NO_BREADCRUMB = 'NO_BREADCRUMB';

// renders and returns the breadcrumb complete with `match`, `location`, and `key` props
const render = ({ breadcrumb, match, location }) => {
const componentProps = { match, location, key: match.path };
const componentProps = { match, location, key: match.url };
if (typeof breadcrumb === 'function') {
return createElement(breadcrumb, componentProps);
}
Expand Down
Loading

0 comments on commit 9acb124

Please sign in to comment.