feat(ci): add static analysis tools (typos, taplo, hadolint, actionlint, shellcheck) #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 CI Reports
🤖 Reports auto-generated from commit 63f7643 |
icook
force-pushed
the
enhance/243-static-analysis
branch
from
e21a414 to
d193644
Compare
icook
force-pushed
the
enhance/243-static-analysis
branch
from
d193644 to
7387e80
Compare
…nt, shellcheck) Add lightweight static analysis pipeline to catch common issues: - typos: spell checker for code, comments, and docs - taplo: TOML formatter/linter for consistent Cargo.toml formatting - hadolint: Dockerfile best practices linter - actionlint: GitHub Actions workflow linter - shellcheck: shell script static analysis Includes: - Configuration files for each tool with sensible defaults - New `just lint-static` recipe and individual tool recipes - CI job running all checks in parallel with existing lints - TOML formatting fixes applied by taplo Closes #243 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
icook
force-pushed
the
enhance/243-static-analysis
branch
from
7387e80 to
e0e6446
Compare
icook
commented
Dec 20, 2025
| - name: Install taplo | ||
| uses: taiki-e/install-action@taplo | ||
|
|
||
| - name: Run static analysis |
Owner
Author
There was a problem hiding this comment.
I think we can toss this, seems like bloat.
icook
commented
Dec 20, 2025
.hadolint.yaml
Outdated
| ignored: | ||
| # Allow unpinned apt packages - we use base image version pinning instead | ||
| - DL3008 | ||
| # Allow additional packages without --no-install-recommends for dev containers |
Owner
Author
There was a problem hiding this comment.
seems like this might be worth enforcing to slim down images
icook
commented
Dec 20, 2025
|
|
||
| # Check for typos in code and docs (requires typos: cargo install typos-cli) | ||
| lint-typos: | ||
| typos |
Owner
Author
There was a problem hiding this comment.
seems like these won't be setup by just setup
icook
commented
Dec 20, 2025
| # Taplo TOML formatter configuration | ||
| # https://taplo.tamasfe.dev/configuration/ | ||
|
|
||
| [formatting] |
Remove actionlint ignore patterns for SC2086 and SC2129, and fix the actual issues throughout the CI workflow: - Quote shell variables in curl URLs and skaffold commands - Quote variables in numfmt commands for bundle size analysis - Use grouped redirects for GITHUB_OUTPUT and GITHUB_STEP_SUMMARY - Quote exit status variable in Playwright test cleanup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove bloated manual tool installs, use taiki-e/install-action@v2 - Enforce DL3015: add --no-install-recommends to service/Dockerfile - Add static analysis tools to just setup output - Document taplo.toml false flags with explanatory comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Owner
Author
|
Addressed all review feedback in 86e4b07:
|
Replace verbose GITHUB_STEP_SUMMARY output with simple tool calls. Use set -x for visibility into what's being run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_typos.tomlconfig (excludes generated files, lock files)taplo.tomlconfig for consistent Cargo.toml formatting.hadolint.yamlconfig.github/actionlint.yamlconfig.shellcheckrcconfigstatic-analysisrunning all tools in paralleljust lint-staticrecipe plus individual tool recipesNew Commands
Test plan
just lint-staticpasses locallyjust lint-backendstill passesstatic-analysisjob passesCloses #243
🤖 Generated with Claude Code