Skip to content

Commit

Permalink
#2691: Do not use AssemblyDefintion.GetAssemblyName().
Browse files Browse the repository at this point in the history
This fails in culture-invariant mode (ilspycmd) when trying to work with satellite assemblies, because System.Reflection.AssemblyName tries to retrieve CultureInfo of the assembly culture.
  • Loading branch information
siegfriedpammer committed May 17, 2022
1 parent a791612 commit c0f0135
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ public static string DetectTargetFrameworkId(this MetadataReader metadata, strin

if (metadata.IsAssembly)
{
var thisAssemblyName = metadata.GetAssemblyDefinition().GetAssemblyName();
switch (thisAssemblyName.Name)
AssemblyDefinition assemblyDefinition = metadata.GetAssemblyDefinition();
switch (metadata.GetString(assemblyDefinition.Name))
{
case "mscorlib":
return $".NETFramework,Version=v{thisAssemblyName.Version.ToString(2)}";
return $".NETFramework,Version=v{assemblyDefinition.Version.ToString(2)}";
case "netstandard":
return $".NETStandard,Version=v{thisAssemblyName.Version.ToString(2)}";
return $".NETStandard,Version=v{assemblyDefinition.Version.ToString(2)}";
}
}

Expand Down

0 comments on commit c0f0135

Please sign in to comment.