Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to Anteater API #1031

Merged
merged 34 commits into from
Nov 18, 2024
Merged

feat: migrate to Anteater API #1031

merged 34 commits into from
Nov 18, 2024

Conversation

ecxyzzy
Copy link
Member

@ecxyzzy ecxyzzy commented Nov 12, 2024

This PR shouldn't have been necessary since in an ideal world we would have skipped API-Next, but oh well.

Summary

  • Set up codegen for types using openapi-typescript, remove ppapi-next-types, and fixup existing usage.
  • Move fetching and most processing logic to backend, and set up tRPC routers and procedures.
    • Notably, we now rely only on the API cache layer for WebSoc, since we don't do anything fancy with it and a 5 minute TTL is probably reasonable. Because the backend now makes the requests, everyone fetching the same endpoint with the same params will hit cache, and as a result we can "invalidate" the cache by passing in a new dummy param.
    • Still caching grades on the frontend though since there's some Interesting logic there.
  • Move away from GraphQL and nuke dead code.

Test Plan

Tested locally, server related things need staging for tests.

Also someone else should run through their normal routine and verify that everything still works as expected.

Things That Still Need Doing

Future Follow-Up

@ecxyzzy ecxyzzy changed the title feat: migrate to Anteater API (WIP) feat: migrate to Anteater API Nov 17, 2024
@ecxyzzy ecxyzzy marked this pull request as ready for review November 17, 2024 02:26
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backend deployment doesn't work. I should've checked that first

apps/backend/src/routers/websoc.ts Show resolved Hide resolved
@MinhxNguyen7
Copy link
Member

Some searches aren't working:
"ICSH32"/"ICS H32" return nothing.
"MAE93" returns nothing, even though it works right now.
"ICS139W" seems to work with fuzzy, but then no results show up

@MinhxNguyen7
Copy link
Member

Should replace these messages about PeterPortal API with Anteater API
image

Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finals part of the tour isn't working. I think it's because you changed the sample data factory

@MinhxNguyen7 MinhxNguyen7 removed the request for review from adcockdalton November 18, 2024 00:50
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

              |    |    |                 
             )_)  )_)  )_)              
            )___))___))___)\            
           )____)____)_____)\\
         _____|____|____|____\\\__
---------\                   /---------
  ^^^^^ ^^^^^^^^^^^^^^^^^^^^^
    ^^^^      ^^^^     ^^^    ^^
         ^^^^      ^^^

@MinhxNguyen7 MinhxNguyen7 merged commit df581af into main Nov 18, 2024
4 checks passed
@ecxyzzy ecxyzzy deleted the anteater-api branch November 18, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants