Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Filter out classes already taken #1161

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

RFC: Filter out classes already taken #1161

wants to merge 5 commits into from

Conversation

vicksey
Copy link
Contributor

@vicksey vicksey commented Feb 12, 2025

Summary

Uses data from PeterPortal to filter out classes that users have taken before the current quarter in their four-year plan.
This feature is implemented with OAuth to pull users' data.

Test Plan

  • Log into a users' account and
  • Toggle on/off the filter feature (UI)
  • Search for a course the user's already taken in the past (their four-year plan) and it shouldn't show up in both the fuzzy search and search list if toggled on
  • Shouldn't filter if toggled off
  • Make sure search is still good

Issues

Closes #1028

To Do:

  • Waiting for PeterPortal endpoint
  • Implement backend filter logic
  • UI component for toggling feature on/off
  • Fetch userId's from auth

@Awesome-E
Copy link
Member

PR on PeterPortal side is up so you can test.
icssc/peterportal-client#598

@github-actions github-actions bot had a problem deploying to staging-backend February 26, 2025 18:04 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Filter out classes already taken
2 participants