Senghoung/edit review feature #59
SenghoungLimlint.yml
on: pull_request
Lint and check formatting
45s
Annotations
1 error and 11 warnings
|
Lint and check formatting
Process completed with exit code 1.
|
|
Lint and check formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Lint and check formatting:
site/src/component/GradeDist/GradeDist.tsx#L70
React Hook useEffect has a missing dependency: 'fetchGradeDistData'. Either include it or remove the dependency array
|
|
Lint and check formatting:
site/src/component/GradeDist/GradeDist.tsx#L81
React Hook useEffect has missing dependencies: 'createCourseEntries', 'createProfEntries', 'props.course', and 'props.professor'. Either include them or remove the dependency array
|
|
Lint and check formatting:
site/src/component/GradeDist/GradeDist.tsx#L88
React Hook useEffect has missing dependencies: 'createQuarterEntries' and 'gradeDistData.length'. Either include them or remove the dependency array
|
|
Lint and check formatting:
site/src/component/Report/ReportGroup.tsx#L21
Unexpected console statement
|
|
Lint and check formatting:
site/src/component/Report/ReportGroup.tsx#L27
React Hook useEffect has a missing dependency: 'props.reviewID'. Either include it or remove the dependency array
|
|
Lint and check formatting:
site/src/component/Report/Reports.tsx#L46
React Hook useEffect has a missing dependency: 'getData'. Either include it or remove the dependency array
|
|
Lint and check formatting:
site/src/component/Review/Review.tsx#L94
React Hook useEffect has missing dependencies: 'dispatch' and 'getReviews'. Either include them or remove the dependency array
|
|
Lint and check formatting:
site/src/component/ReviewForm/ReviewForm.tsx#L107
React Hook useEffect has missing dependencies: 'cookies.user' and 'props'. Either include them or remove the dependency array. However, 'props' will change when *any* prop changes, so the preferred fix is to destructure the 'props' object outside of the useEffect call and refer to those specific props inside useEffect
|
|
Lint and check formatting:
site/src/component/Schedule/Schedule.tsx#L31
React Hook useEffect has a missing dependency: 'fetchScheduleDataFromAPI'. Either include it or remove the dependency array
|
|
Lint and check formatting:
site/src/component/SideBar/SideBar.tsx#L38
React Hook useEffect contains a call to 'setName'. Without a list of dependencies, this can lead to an infinite chain of updates. To fix this, pass [isLoggedIn, checkAdmin, cookies.user.name, cookies.user.picture] as a second argument to the useEffect Hook
|