Skip to content

Search box for when you click on a course page and the professor box#1007

Merged
JasonNguyen067 merged 23 commits into
mainfrom
searchError
Apr 25, 2026
Merged

Search box for when you click on a course page and the professor box#1007
JasonNguyen067 merged 23 commits into
mainfrom
searchError

Conversation

@JasonNguyen067
Copy link
Copy Markdown
Contributor

@JasonNguyen067 JasonNguyen067 commented Feb 27, 2026

Added a search box

Screenshot 2026-02-26 at 4 10 13 PM

You can test this by navigating to a course, clicking on the professor and typing a professors name in the search box.

@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 February 27, 2026 00:11 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 February 27, 2026 00:12 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 February 27, 2026 04:56 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 February 27, 2026 04:57 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 March 5, 2026 15:45 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 March 5, 2026 15:45 Inactive
Copy link
Copy Markdown
Collaborator

@CadenLee2 CadenLee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this mostly works, though I have a few concerns. Mostly these'll be resolved once #968 is merged and this is updated

Comment thread site/src/component/GradeDist/GradeDist.scss
Comment thread site/src/component/GradeDist/GradeDist.tsx Outdated
Comment thread site/src/component/GradeDist/GradeDist.tsx Outdated
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 March 9, 2026 18:54 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 March 9, 2026 18:54 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 18, 2026 23:53 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 18, 2026 23:53 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 19, 2026 00:01 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 19, 2026 00:01 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 19, 2026 00:05 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 19, 2026 00:06 Inactive
Copy link
Copy Markdown
Collaborator

@CadenLee2 CadenLee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this mostly works, but don't forget that we decided on using MUI autocomplete instead of putting a text field inside the list.

Ideally the Select should just be replaced with an autocomplete, and it should be able to handle a lot of the logic for us

@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 20, 2026 22:07 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 20, 2026 22:07 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 20, 2026 22:15 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 20, 2026 22:15 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 22, 2026 07:58 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 22, 2026 07:58 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 24, 2026 02:18 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 24, 2026 02:18 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 24, 2026 02:38 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 24, 2026 02:38 Inactive
Copy link
Copy Markdown
Collaborator

@CadenLee2 CadenLee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final change...

otherwise lgtm

Comment thread site/src/component/GradeDist/GradeDist.tsx
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 24, 2026 19:34 — with GitHub Actions Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 24, 2026 19:57 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 24, 2026 19:58 Inactive
@JasonNguyen067 JasonNguyen067 temporarily deployed to staging-1007 April 24, 2026 20:52 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1007 April 24, 2026 20:53 Inactive
Copy link
Copy Markdown
Collaborator

@CadenLee2 CadenLee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💵

@JasonNguyen067 JasonNguyen067 merged commit 873d23c into main Apr 25, 2026
4 checks passed
@JasonNguyen067 JasonNguyen067 deleted the searchError branch April 25, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants