Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Icon indicating you authored review #412

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

timobraz
Copy link
Contributor

@timobraz timobraz commented Feb 1, 2024

Description

Added icon next to the verification badge that indicates you're the author of the review when your userid (assuming you're already authed) matches with the userid of the review's author.

Screenshots

image

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #407

@timobraz timobraz requested a review from js0mmer February 1, 2024 01:48
@timobraz timobraz self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Deployed staging instance to https://staging-412.peterportal.org

Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. In my opinion, it would look a little cleaner if the person fill icon were also in a badge. See suggestion.

image

site/src/component/Review/SubReview.tsx Show resolved Hide resolved
site/src/component/Review/SubReview.tsx Show resolved Hide resolved
site/src/component/Review/SubReview.tsx Show resolved Hide resolved
@timobraz timobraz merged commit e0f9318 into master Feb 2, 2024
3 checks passed
@timobraz timobraz deleted the tim/authored-review-icon branch February 2, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tag that shows reviews you've authored
2 participants