Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty quarter because we use grids now #484

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Remove empty quarter because we use grids now #484

merged 1 commit into from
Sep 2, 2024

Conversation

Awesome-E
Copy link
Member

Description

Remove the empty-quarter elements because they just showed up as empty boxes of different size in our grid.

Screenshots

Before:
image

After:
image

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

@Awesome-E Awesome-E requested a review from js0mmer August 29, 2024 15:17
@Awesome-E Awesome-E temporarily deployed to staging-484 August 29, 2024 15:18 — with GitHub Actions Inactive
js0mmer
js0mmer approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Awesome-E Awesome-E merged commit 820ed90 into master Sep 2, 2024
2 checks passed
@Awesome-E Awesome-E deleted the remove-empty-quarter branch September 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js0mmer js0mmer js0mmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Awesome-E @js0mmer