Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rounding for instructor rating in course popup #485

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Added rounding for instructor rating in course popup #485

merged 1 commit into from
Sep 30, 2024

Conversation

vinnyho
Copy link
Contributor

@vinnyho vinnyho commented Sep 25, 2024

Description

Added checking to see whether it was a single digit integer, if so, it wouldn't add two extra zeroes like currently. Though if it was a long decimal, added a fixed rounding of two.

Steps to verify/test this change:

  • Used same method of rounding from other parts of the code
  • Made sure that the type and variable worked with it

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #
#371

@vinnyho
Copy link
Contributor Author

vinnyho commented Sep 27, 2024

Sorry, do you have feedback on what I did wrong?

@js0mmer
Copy link
Member

js0mmer commented Sep 27, 2024

Sorry, do you have feedback on what I did wrong?

No, your changes look good to me! I'm not sure why it failed to deploy, that's something on our end I'll have to look into.

@js0mmer js0mmer self-requested a review September 30, 2024 02:09
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@js0mmer js0mmer merged commit d858051 into icssc:master Sep 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants