Fixes for 64bit indices #4429
Merged
Fixes for 64bit indices #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-id-bytes=8. Refs idaholab#4321.
--with-dof-id-bytes configurations. Restricting the aux_nonlinear_solution_from_xdr to only run when libmesh has been configured with 4-byte dof ids. Refs idaholab#4321.
|
Results of testing 9796318 using moose_PR_pre_check recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/9723 |
|
Results of testing 9796318 using moose_PR_test recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/9724 |
|
Results of testing 9796318 using moose_PR_test_dbg recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/9725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch gets MOOSE compiling and running when PETSc is configured with
--with-64-bit-indices=1, and libmesh is configured with--with-dof-id-bytes=8.This commit shouldn't break anything for anyone using 32-bit indices, it's basically enforcing consistent use of
dof_id_typeoverunsigned intwhere necessary. By the same token, new invalid uses ofunsigned intwill probably continue to creep into the code unless we're really vigilant, so it might be worth creating a "big indices" build target going forward...Refs #4321.