Skip to content
GitHub Actions / clippy failed Dec 5, 2023 in 2s

clippy

74 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 74
Warning 0
Note 0
Help 0

Versions

  • rustc 1.74.0 (79e9716c9 2023-11-13)
  • cargo 1.74.0 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (79e9716 2023-11-13)

Annotations

Check failure on line 323 in src/participants.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

panic message is not a string literal

error: panic message is not a string literal
   --> src/participants.rs:323:26
    |
323 |             unreachable!(false);
    |                          ^^^^^
    |
    = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
    = note: `#[deny(non_fmt_panics)]` implied by `#[deny(warnings)]`
help: add a "{}" format string to `Display` the message
    |
323 |             unreachable!("{}", false);
    |                          +++++

Check failure on line 738 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:738:15
    |
738 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 721 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:721:15
    |
721 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 702 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:702:15
    |
702 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 683 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:683:15
    |
683 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 665 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:665:15
    |
665 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 648 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:648:15
    |
648 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 631 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:631:15
    |
631 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 606 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:606:15
    |
606 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 580 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:580:15
    |
580 |             id.to_string()
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 564 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:564:15
    |
564 |             id.to_string()
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 552 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:552:15
    |
552 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 535 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:535:15
    |
535 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 519 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:519:15
    |
519 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 502 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:502:15
    |
502 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 480 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:480:15
    |
480 |             id.to_string(),
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 466 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value

error: this let-binding has unit value
   --> src/lib.rs:466:9
    |
466 |         let _: () = serde_json::from_reader(response)?;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `serde_json::from_reader(response)?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
    = note: `#[deny(clippy::let_unit_value)]` implied by `#[deny(warnings)]`

Check failure on line 462 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:462:15
    |
462 |             id.to_string()
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 445 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:445:15
    |
445 |             id.to_string()
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 430 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:430:15
    |
430 |             id.to_string()
    |               ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 366 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:366:66
    |
366 |         let url = &format!("{}/tournaments/{}.json", API_BASE, id.to_string());
    |                                                                  ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 358 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:358:66
    |
358 |         let url = &format!("{}/tournaments/{}.json", API_BASE, id.to_string());
    |                                                                  ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 291 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
   --> src/lib.rs:291:80
    |
291 |             reqwest::Url::parse(&format!("{}/tournaments/{}.json", API_BASE, id.to_string()))
    |                                                                                ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check failure on line 272 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

error: the borrowed expression implements the required traits
   --> src/lib.rs:272:40
    |
272 |         let response = self.client.get(&url).send()?;
    |                                        ^^^^ help: change this to: `url`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[deny(clippy::needless_borrows_for_generic_args)]` implied by `#[deny(warnings)]`

Check failure on line 40 in src/macroses.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/macroses.rs:40:23
    |
40  |         pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self {
    |                       ^^   ^^                                    ^^
    |
   ::: src/tournament.rs:296:5
    |
296 |     builder!(grand_finals_modifier, Option<String>);
    |     -----------------------------------------------
    |     |
    |     in this macro invocation
    |     in this macro invocation
    |     in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info)
help: elide the lifetimes
    |
40  -         pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self {
40  +         pub fn $field(&mut self, $field: $field_type) -> &mut Self {
    |