Add support for fields that match go reserved names #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusvniekerk
force-pushed
the
go-reserved-words
branch
from
257eb58
to
227dbb7
Compare
|
Hey @mariusvniekerk, |
idodod
reviewed
May 3, 2024
Earthfile
Outdated
Comment on lines
3
to
5
| ARG --global ALPINE_VERSION=3.19 | ||
| ARG --global GO_VERSION=1.22 | ||
| ARG --global LINTER_VERSION=v1.57.2 |
There was a problem hiding this comment.
I'm not sure this is necessary, is it?
There was a problem hiding this comment.
might not be necessary, i vaguely recall running into issues with eathly 0.8+ without it i think
Comment on lines
-54
to
-56
| if len(message.Fields) == 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
yes, without this messages with zero fields have issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds and extend on pull request #12
Fixes #2 and likely fixes #46
I've added a test case to show the example case