Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ftc #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Merge ftc #2

wants to merge 2 commits into from

Conversation

inhar-andueza
Copy link

No description provided.

@ielorza
Copy link
Owner

ielorza commented Apr 11, 2018

ResetSignal is a private member of ikSensorDiagnoser according to ikWitcon style, hence its being before the @endcond tag. No provision has been made for ResetSignal modification, other than direct assignment, which would be in violation of its private nature.

@ielorza
Copy link
Owner

ielorza commented Apr 11, 2018

Please abstain from tab changes and such clutter, unless they are done on purpose and in a format-related commit.

@ielorza
Copy link
Owner

ielorza commented Apr 11, 2018

You must provide a regression test for the new feature. That would go in ikSensorDiagnoser_test.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants