Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Introduced publish-subscribe model. #43

Closed
wants to merge 3 commits into from
Closed

Draft: Introduced publish-subscribe model. #43

wants to merge 3 commits into from

Conversation

eckelmeckel
Copy link
Collaborator

Resolves #42.

  • Introduced publish-subscribe model.
  • Removed "delta" TODO as there was nothing to be fixed.
  • Fixed line break in uni-directional diagram.

Signed-off-by: Michael Eckel [email protected]

@eckelmeckel
Introduced publish-subscribe model.
048d43f 
* Removed "delta" TODO as there was nothing to be fixed.
* Fixed line break in uni-directional diagram.

Signed-off-by: Michael Eckel <[email protected]>
@eckelmeckel eckelmeckel added the enhancement New feature or request label Jul 7, 2021
@eckelmeckel eckelmeckel force-pushed the add-pubsub-attestation-model branch from a3b7e76 to e05ce9c Compare July 7, 2021 22:49
@ericvoit
Copy link

I think that this Pull is premature for commit. Several reasons include:

(1) It introduces new terms / roles which are not included in the Architecture document. E.g., the PubSub server.

(2) This seems to be a very large scope change to an already adopted document. Likely there needs to be discussion on the list of the meaning of the functionality.

(3) There is draft-birkholz-rats-network-device-subscription which includes items like Subscription identifier. However this PR doesn't describe the relationship to draft-birkholz-rats-network-device-subscription.

(4) Basic questions on capability discovery (like how to know what streams are available for subscription) are already handled elsewhere in places like NETCONF, RESTCONF, etc. Do we need additional documents describing these functions specific to RATS?

henkbirkholz
henkbirkholz requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@henkbirkholz henkbirkholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this content should fuel an additional I-D that provides guidance and orchestration, as it would add new roles and has to be harmonized with other I-Ds close to adoptions (such as network device subscription). Not abandoned, but deferred.

@henkbirkholz henkbirkholz changed the title Introduced publish-subscribe model. Draft: Introduced publish-subscribe model. Jul 26, 2021
@henkbirkholz henkbirkholz mentioned this pull request Jul 26, 2021
Closed
henkbirkholz added a commit that referenced this pull request Jul 26, 2021
@henkbirkholz
nits fixed by Michael transplanted here from PR #43
919c676
henkbirkholz added a commit that referenced this pull request Jul 26, 2021
@henkbirkholz
Merge pull request #45 from ietf-rats-wg/michaels-polish
0d3b884 
nits fixed by Michael transplanted here from PR #43
@henkbirkholz
Copy link
Member

Abandoning this item for the moment to become future work in a different document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henkbirkholz henkbirkholz henkbirkholz requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish-Subscripe Attestation may be nice to have
3 participants
@eckelmeckel @ericvoit @henkbirkholz