fix: stop reconnecting SSH before every file by default (#17)#27
Merged
Conversation
Stop thrashing SSH sessions by skipping per-file reconnect unless operators opt in via Worker/factory reconnect= or OELEO_RECONNECT. Failed moves still reconnect once and retry. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Move issue #17 original/plan/status into 03-solved-issues after REL-01 reconnect default fix landed and tests passed. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
jepegit
marked this pull request as ready for review
July 17, 2026 15:33
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17 (REL-01):
Workerno longer reconnects the destination connector before every changed file by default (SSH session thrashing).Worker.reconnectisFalsesimple_worker,ssh_worker,sharepoint_worker) acceptreconnect=and honorOELEO_RECONNECTwhen the kwarg is omitted.env_exampledocument the opt-in.issueflows/03-solved-issues/Test plan
uv run pytest -m "not ssh"— 25 passed (5 new reconnect tests)app/oa.pywSSH runs keep a single session unlessOELEO_RECONNECT=true