fix: shell-safe remote path handling in SSHConnector (#18)#28
Merged
Conversation
Add SSHConnector._remote_shell_token (shlex.quote on POSIX) and use it for find/md5sum/mkdir and debug helpers so spaces and metacharacters cannot break or inject remote commands. Unit tests assert command shape; gated SSH integration covers paths with spaces. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Move issue #18 original/plan/status into 03-solved-issues after SEC-01 shell-quoting fix landed and tests passed. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
calculate_checksum was the only production shell call missing in_stream=False, which breaks pytest-captured SSH CI when the new space-in-path integration test exercises md5sum. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
jepegit
marked this pull request as ready for review
July 17, 2026 15:42
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #18 (SEC-01): quote every interpolated token in
SSHConnectorremote shell commands so spaces and metacharacters cannot break or inject commands.SSHConnector._remote_shell_token(shlex.quoteon POSIX; best-effort Windows wrap)find/md5sum/mkdir -pand debug connect helperscalculate_checksumnow passesin_stream=False(fixes pytest stdin capture in SSH CI).issueflows/03-solved-issues/Test plan
uv run pytest -m "not ssh"— 25 passedsshjob (re-run afterin_stream=Falsefix)