Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track Progress on Strategies #1719
Track Progress on Strategies #1719
Changes from 37 commits
36cf917
e1430fb
06a14fd
7b1e9f3
fd45438
671c57c
b2fbf3f
130080c
201cf50
074fa4f
05ea003
b700bdd
e7ce1e1
a40700f
343d750
f793949
69fef40
1b625c5
4839cdd
06aa0fd
a986ce4
d2f9030
6c2a1b4
3d56560
fd883c3
6ee81d5
2ca7062
3cf1569
06bcd2f
1e088d4
719c25e
61c4502
15700e5
96a5301
0ec0bad
4b365c9
1089f6d
a8adbef
b360190
957f671
d001eb8
6d40000
dfa599d
f41b5b8
1656963
9d5c6d5
3b5f6a3
69b38aa
895707e
349021d
b2e87d3
2db2e2d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be testing for this new task functionality in the test for update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be testing for this new task functionality in the test for destroy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this and exclude this route in
routes.rb
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need this route?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be unit testing this helper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should handle errors in the event that save does not work.