[pull] main from sveltejs:main #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix cloudflare docs * gah missed a spot
fixes #13095 This PR changes the RegExp to ensure that routes such as /[[optional]]/(group) are treated the same as [[optional]]. Previously, /[[optional]]/(group) was being treated the same as / which is incorrect since it has an optional segment. It wasn't recognised as /[[optional]] because the RegExp didn't consider the route group preceding it (it only looked for the end of the string).
* add other packages to pkg.pr.new * Update .github/workflows/ci.yml Co-authored-by: Ben McCann <[email protected]> --------- Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…om `hooks.server.js` (#13104) * specifically write to each property * changeset * Update .changeset/mean-bottles-wash.md
* feat: server and client `init` hook * fix: provide client_hooks fallback even if universal hooks are present * chore: add tests * chore: cache server instance in `vite dev` * chore: remove only (duh) * chore: revert single server in dev * chore: revert weird did_it_run thing * chore: add additional inited check to prevent multiple init in case of race conditions * fix: remove `init` from client hooks * docs: write some documentation, use proper exported types * chore: regenerate types * simplify * chore: docs suggestions from review Co-authored-by: Rich Harris <[email protected]> * try this * chore: fix lint * chore: fix types * save a couple bytes * Apply suggestions from code review --------- Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Simon H <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs: note when `init` hook was added * add `@since` tags * on second thoughts, just use the tags
fixes #13100 This PR adds a check to see if an index file exists in the related directory before resolving to that path. Directories without an index file should correctly fallback to the non-directory path.
#13148) * feat: support wrangler.json * feat: Find the wrangler.json if the default config not found * Update packages/adapter-cloudflare-workers/index.js --------- Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben McCann <[email protected]>
* write server to _worker.js directory * add changeset
…static` (#13227) * docs * fix * fix again * add service worker link * grammar * try to fix docs deployment * copy files from project root instead of /static * Update .changeset/few-apricots-study.md * add error message to netlify adapter
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rendering (#13616) * fix: allow non-prerendered API endpoint calls during reroute when prerendering * test * tweak * fix other prerendering bug * lint
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…3593) * add fix and test * changeset * format
* docs: flesh out icons section and make standalone page * Update documentation/docs/40-best-practices/06-icons.md Co-authored-by: Tee Ming <[email protected]> --------- Co-authored-by: Tee Ming <[email protected]>
…oudflare` (#13634) * merge adapters * changeset * it's valid to not specify a main entry if the user is only deploying static assets * format * adjust docs * also use cf pages env var * fix migration guide link * try to fix doc build error * Update index.d.ts Co-authored-by: Ben McCann <[email protected]> * Update kind-carrots-deliver.md Co-authored-by: Ben McCann <[email protected]> * validate assets key if main key is set * delete adapter-cloudflare-workers * adjust docs and workspace for removing cloudflare workers * fix docs title * clarify _routes.json belongs to cloudflare pages * Update packages/adapter-cloudflare/src/worker.js Co-authored-by: Ben McCann <[email protected]> * changes according to feedback * revert type change * fix lock file * fixes * tests * fix lockfile * format --------- Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
this should hopefully make the editor experience more stable, as the chance of the world being loaded in is minimized. Previously (I think) the import of the general utils file from any of the project's test files meant that as soon as you open one test project, all the test projects at once were loaded into memory, including stuff from .svelte-kit, because the general test config didn't have an include config. Also removes an unnecessary duplicate from the kit root tsconfig
We previously used a grotesque hack that would ensure the HttpError etc classes would be the same between what Vite imports via its transformation toolchain and what you get from a regular node import. Turns out we don't need that anymore - since #9242 SvelteKit is guaranteed to always be loaded through the Vite toolchain.
…ows (#13671) * fix fixes #13667 This PR uses the non-posix relative() method so that it correctly resolves when used with Windows paths that may be provided through the Wrangler configuration. It also converts the path to a POSIX path before embedding them into the worker script since backslashes get interpreted as escape characters and are lost in the process. Also includes a minor fix where if the user had pages_build_output_dir set in their wrangler configuration, the adapter wasn't writing the worker to that directory (Cloudflare Pages expects the worker and assets to be in the same directory).
* Implement better build output using symlinks * snake_case * prettier * explanatory comment * generate symlinks when app uses function splitting * improve internal function naming and eliminate conflicts * changeset --------- Co-authored-by: Tobias Lins <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )