-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "no_wait" mode for file synchronization #1425
Conversation
dbd5f09
to
1f65bbe
Compare
Pull Request Test Coverage Report for Build 12687277738Details
💛 - Coveralls |
1f65bbe
to
52cfd04
Compare
Great job, I can certainly see the improvements with
I will do a few more tests tomorrow on Linux PC, but it looks like it could be merged already :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and works even better :) Please update the Cargo.toml
in server to 0.4.100
so that it will be automatically released.
And a quick update after running the same benchmark for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces a new "no_wait" mode to the file synchronization process. The "nowait" mode allows file operations to proceed without waiting for certain synchronization steps to complete, improving performance in scenarios where blocking is unnecessary