Merge pull request #5 from ignurof/main

Another Update

404.html

@@ -45,7 +45,7 @@
         <main>
             <section class="call-to-action">
                 <p class="center">Oops! Something went wrong :(</p>
-                <button><a href="index.html" aria-label="Go to the Home page of the site">Go to Home</a></button>
+                <a class="button" href="index.html" aria-label="Go to the Home page of the site">Go to Home</a>
             </section>
         </main>
 

README.md

@@ -4,6 +4,8 @@ howtosowseeds.com is an informational guide site to help people around the world
 The intention is to bring more people into the gardening hobby and the main target demographic of the site is beginners to gardening and anything related to seed sowing. 
 howtosowseeds.com will be a good place of reference for gardeners to know just when and how to sow their seeds even when they're not beginners anymore.
 
+Visit the site here: https://ignurof.github.io/www-howtosowseeds-com
+
 ![Responsiveness](https://www.ignurof.com/responsive.png)
 
 # Table of Contents
@@ -85,7 +87,7 @@ Every button has been pressed and investigated more than hundres of times throug
 The website has also been combed through with the use of a android phone to make sure that the mobile-first design has always been grounded in the real world!
 After completed development cycle I have also gone through the whole site one last time to make sure I did not miss anything, and through the whole development process I have taken notes and crossed of those notes whenever I noticed there was a task that needed to be taken care of, for example seeing something not being perfectly responsive during testing I would note that down, keep testing and then return to address whatever the issue was when development was resumed.
 
-After all was said and done with above testing and I noted that everything looked right, I ran the site through a HTML validator and CSS validator to go the extra mile and make sure I covered all my bases. The CSS was top notch but I had 4 unfixed bugs to deal with in the HTML, but nothing that affects the functionality, look or features or the website so they could be postponed from the MVP.
+After all was said and done with above testing and I noted that everything looked right, I ran the site through a HTML validator and CSS validator to go the extra mile and make sure I covered all my bases. The CSS was top notch but I had 4 unfixed bugs to deal with in the HTML, so I had to go through again and fix those before deploying.
 
 To cover all my bases since I have tested on Firefox and also an android phone which user Google Chrome, I wanted to make sure I also test using and hopefully not breaking the site while navigating around with Google Chrome on my laptop as one final test.
 Everything looked like it did previously except in a different browser which means the site definitely passes the testing stage.
@@ -102,11 +104,7 @@ CSS was tested through the jigsaw.w3.org css specific validator found here: http
 
 ### Unfixed Bugs
 
-The four unfixed bugs currently deployed in production are the ones shown above that failed the HTML validation testing.
-- Element div not allowed as child of element label in this context.
-- The element button must not appear as a descendant of the a element.
-- The element button must not appear as a descendant of the a element.
-- Stray start tag script.
+None
 
 ## Deployment
 

assets/css/global.css

@@ -30,7 +30,7 @@ body {
     text-align: center;
 }
 
-button > a {
+.button {
     color: white;
     text-decoration: none;
 }
@@ -190,7 +190,7 @@ main > section .image {
     align-items: center;
 }
 
-.call-to-action > button {
+.call-to-action > .button {
     font-size: 160%;
     font-weight: bold;
     text-transform: uppercase;
@@ -202,12 +202,12 @@ main > section .image {
     color: white;
 }
 
-.call-to-action > button:hover {
+.call-to-action > .button:hover {
     background-color: var(--main-link-color);
     box-shadow: inset 0 0 0 0.4rem var(--cta-color);
 }
 
-.call-to-action > button:active {
+.call-to-action > .button:active {
     box-shadow: inset 0 0 0 0.1rem var(--cta-color);
 }
 
@@ -342,7 +342,7 @@ footer > p > a {
         gap: 4rem;
     }
 
-    .call-to-action > a > button {
+    .call-to-action > .button {
         padding: 2rem 2rem 2rem 2rem;
     }   
 }
@@ -437,7 +437,7 @@ footer > p > a {
     }
 
     /* hide hamburger menu */
-    header > label {
+    .nav-hamburger {
         display: none;
     }
 

index.html

@@ -46,7 +46,7 @@
             <section class="call-to-action">
                 <h2 style="visibility: hidden; height: 0;">Home</h2> 
                 <p>Welcome to this informational guide website, designed and developed to bring more people into the gardening lifestyle while also existing as a great source of knowledge and reference for those that have been doing gardening for a while.</p>
-                <button><a href="guide.html" aria-label="Go to the Guide page of the site">Read Guide</a></button>
+                <a class="button" href="guide.html" aria-label="Go to the Guide page of the site">Read Guide</a>
                 <p>A safe haven for beginners and professionals alike, a place to come together and learn all about how to sow seeds.</p>
             </section>
         </main>

thanks.html

@@ -45,7 +45,7 @@
         <main>
             <section class="call-to-action">
                 <p class="center">Thank you for submitting the form!</p>
-                <button><a href="index.html" aria-label="Go to the Home page of the site">Go to Home</a></button>
+                <a class="button" href="index.html" aria-label="Go to the Home page of the site">Go to Home</a>
             </section>
         </main>