This repository has been archived by the owner on Oct 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
Add xhr object to callbacks. Add additional header X-Wiselinks-Target. #94
Open
phlegx
wants to merge
20
commits into
igor-alexandrov:master
Choose a base branch
from
phlegx:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the request header (X-Wiselinks-Scope). This helps to send additional data to the controller without using params. Example: <a href="..." data-scope="some string">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add xhr object to callbacks
To handle headers in Wiselinks callbacks (javascript events) I have added xhr in callbacks for page:fail, page:redirected, page:done. The xhr in the callbacks can be very useful.
Example
Javascript Events
Add additional header X-Wiselinks-Target
The target, if used in the link or form, gets included in the header data and can be retrieved with
request.wiselinks_target
in the controller.Add additional header X-Wiselinks-Scope
The scope, if used in the link or form (data-scope=), gets included in the header data and can be retrieved with
request.wiselinks_scope
in the controller.