forked from ImagingDataCommons/dicom-microscopy-viewer
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(annotations): Annotations styles hardening #3
Draft
igoroctaviano
wants to merge
233
commits into
igoroctaviano:master
Choose a base branch
from
RadicalImaging:fix/microscopy-annotations-hardening
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix(annotations): Annotations styles hardening #3
igoroctaviano
wants to merge
233
commits into
igoroctaviano:master
from
RadicalImaging:fix/microscopy-annotations-hardening
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
igoroctaviano
commented
Nov 25, 2021
- Fix active style for ellipse: when selecting annotation in the right panel the label was permanently set with active color.
- Fix bidirectional short axis style: when loading bidirectional from sr the short axis didn't have the same style as long axis.
- Fix ellipse multiple markup: before ellipse was displaying more than one measurement markup.
Values with these Value Representations may be represented in DICOM JSON as either a String or a Number. Convert the values to a Number for consistent behaviour across different image management systems.
…option-to-add-overlay Add new function to add map overlays
…icroscopy-viewer into feat/bidirectional
Stores values in mm or mm^2, and then formats the values to micro m, m etc as required.
fix(dicom-microscopy-viewer):Fix the units display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.