Skip to content

Update dependency io.nlopez.compose.rules:ktlint to v0.5.1 #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency io.nlopez.compose.rules:ktlint to v0.5.1 #774

renovate wants to merge 1 commit into from

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 21, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
io.nlopez.compose.rules:ktlint 0.4.27 -> 0.5.1 age confidence

Release Notes

mrmans0n/compose-rules (io.nlopez.compose.rules:ktlint)

v0.5.1

What's changed

Dependency Matrix

version kotlin version
detekt 2.0.0-alpha.1 2.2.20
ktlint 1.8.0 2.2.21

v0.5.0

[!IMPORTANT]
This version targets detekt 2.x (specifically, 2.0.0-alpha.1). It is incompatible with earlier detekt 1.x versions, so if you are using those, DO NOT UPDATE.

What's changed

Dependency Matrix

version kotlin version
detekt 2.0.0-alpha.1 2.2.20
ktlint 1.8.0 2.2.21

v0.4.28

Notably, the only real "functional" change in this release is that ktlint is now targeting version 1.8.0, compiled against kotlin 2.2.21.

What's changed

Dependency Matrix

version kotlin version
detekt 1.23.8 2.0.21
ktlint 1.8.0 2.2.21

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/nlopez.compose.rules branch from 247c12f to f73fe41 Compare December 3, 2025 10:51
@renovate renovate bot changed the title Update dependency io.nlopez.compose.rules:ktlint to v0.4.28 Update dependency io.nlopez.compose.rules:ktlint to v0.5.0 Dec 3, 2025
@claude
Copy link

claude bot commented Dec 4, 2025

Pull Request Review: Update io.nlopez.compose.rules:ktlint to v0.5.0

Summary

This PR updates the compose-rules ktlint dependency from v0.4.27 to v0.5.0. This is a Renovate-generated dependency update that requires careful review due to breaking changes.

⚠️ Critical Breaking Changes

MAJOR VERSION BUMP - REQUIRES ATTENTION

The release notes for v0.5.0 clearly state:

IMPORTANT: This version targets detekt 2.x (specifically, 2.0.0-alpha.1). It is incompatible with earlier detekt 1.x versions, so if you are using those, DO NOT UPDATE.

Current Project Status:

  • Current detekt version: 1.23.8 (from gradle/libs.versions.toml:37)
  • Required detekt version: 2.0.0-alpha.1 or higher
  • Kotlin version: 2.2.21 ✅ (compatible - v0.5.0 uses kotlin 2.2.21 for ktlint)

Compatibility Issue: This update is INCOMPATIBLE with the current detekt version and will likely cause build failures.

Code Quality Assessment

✅ Change Quality: The code change itself is clean and minimal - single version bump in the version catalog.

✅ Configuration: The dependency is properly configured in:

  • gradle/libs.versions.toml:44 - version declaration
  • build-logic/src/main/kotlin/com/igorwojda/showcase/buildlogic/SpotlessConventionPlugin.kt:22 - used as custom ruleset for ktlint

Recommendations

DO NOT MERGE until one of the following actions is taken:

Option 1: Update detekt to v2.x (Recommended for staying current)

  1. Update detekt version in gradle/libs.versions.toml from 1.23.8 to 2.0.0-alpha.1 or later
  2. Review detekt 2.x migration guide for any breaking changes
  3. Run full test suite and linting checks
  4. Note: This introduces an alpha dependency which may not be suitable for production

Option 2: Hold this update (Recommended for stability)

  1. Close this PR and configure Renovate to skip this update until detekt 2.x is stable
  2. Wait for detekt 2.0 stable release
  3. Coordinate both updates together in a dedicated migration PR

Option 3: Revert to compatible version

  1. Update to the latest v0.4.x release (v0.4.28) instead
  2. This version supports ktlint 1.8.0 and kotlin 2.2.21 without requiring detekt 2.x

Security Concerns

✅ No security issues identified in this dependency update.

Performance Considerations

⚠️ Build Performance: The v0.5.0 release notes mention:

  • Migration to Detekt 2.0
  • Updated dependencies (kaml, shadowJar, compose-bom)
  • Integration tests added

These changes suggest potential build time impacts that should be monitored after upgrade.

Test Coverage

✅ Existing Tests: Project has 23 test files
⚠️ Testing Required: After resolving the detekt compatibility issue, ensure:

  1. All ktlint checks pass: ./gradlew spotlessCheck
  2. All detekt checks pass: ./gradlew detekt
  3. Full test suite passes: ./gradlew test
  4. Build succeeds: ./gradlew build

Additional Notes

What's New in v0.5.0:

  • Detekt 2.0 support
  • Kotlin 2.2.20+ support
  • New default ViewModel factories
  • Bug fixes in shadowjar configuration
  • Real world samples for integration testing

Repository Context:

  • Using Spotless with ktlint for code formatting
  • Custom rulesets include: ktlint-ruleset-standard (v1.8.0), nlopez-compose-rules, twitter-compose-rules
  • EditorConfig properly configured with ktlint settings

Verdict

BLOCK MERGE - This PR introduces an incompatible dependency version. Please address the detekt version incompatibility before proceeding.

The most prudent path forward is Option 2 (hold this update) until detekt 2.0 reaches a stable release, then coordinate both updates together in a dedicated migration effort.

📚 References:

🤖 Review generated with Claude Code

@renovate renovate bot changed the title Update dependency io.nlopez.compose.rules:ktlint to v0.5.0 Update dependency io.nlopez.compose.rules:ktlint to v0.5.1 Dec 4, 2025
@renovate renovate bot force-pushed the renovate/nlopez.compose.rules branch from f73fe41 to f72fcc2 Compare December 4, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant