Parse objects from config itself with as[] #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailuowang
reviewed
Oct 17, 2017
| @@ -9,6 +9,8 @@ trait FicusConfig { | |||
|
|
|||
| def as[A](path: String)(implicit reader: ValueReader[A]): A = reader.read(config, path) | |||
|
|
|||
| def as[A](implicit reader: ValueReader[A]): A = reader.read(config, ".") | |||
There was a problem hiding this comment.
this is a nit, how about we make it
def as[A](implicit reader: ValueReader[A]): A = as(".")The intention here is to expose the fact that if you pass in a "." as path you get the same result as as.
|
Thanks! I think this would work. I left a minor comment. |
|
@kailuowang done! |
kailuowang
approved these changes
Oct 18, 2017
|
1.4.3 released |
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw another pull request #51 too late and I offer a less flexible, but simpler solution to the problem #8