Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse hessian to deal with multiple or incomplete observations #8

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

zhengp0
Copy link
Member

@zhengp0 zhengp0 commented Jun 7, 2024

Allow number of rows in data to be different than number of variables

  • create design matrix using jax.experimental.sparse.BCOO
  • replace the original hessian_diag function by hessian in the likelihood (this will influence model.hessian and preconditioner)
  • added a extra argument called data_span in the function KernelRegModel.fit, in case data is incomplete and does not contain all coordinate we are interested.
  • added a predict function for convenient prediction

Note

@zhengp0 zhengp0 requested review from kels271828 and AHsu98 June 7, 2024 02:14
@AHsu98
Copy link
Contributor

AHsu98 commented Jun 7, 2024

We should meet about this. I think we can generically handle multiple observations by wrapping into a modified likelihood. The only time we have a non diagonal hessian for the likelihood is when it involves a sum of multiple predictions (integral or something). I’m also about to push some minor changes I ran into from doing the sub national estimation from Reed.

@zhengp0
Copy link
Member Author

zhengp0 commented Jun 7, 2024

We should meet about this. I think we can generically handle multiple observations by wrapping into a modified likelihood. The only time we have a non diagonal hessian for the likelihood is when it involves a sum of multiple predictions (integral or something). I’m also about to push some minor changes I ran into from doing the sub national estimation from Reed.

That sounds good! I will send an invite, sorry just saw this. I will leave this PR open until we discuss.

@zhengp0 zhengp0 merged commit 37f0992 into main Oct 16, 2024
@zhengp0 zhengp0 deleted the feature/sparse-hessian branch October 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants