Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _infer_shape function to the ensemble class #60

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

zhengp0
Copy link
Member

@zhengp0 zhengp0 commented Oct 15, 2024

In the most recent version we introduce CatCovModel where introduce uncertainty about the dimension of the model. And we added _infer_shape function to the MRBRT class to obtain size of the model after we attach the data.

However in the ensemble class MRBeRT we still try to set the dimensions in the __init__ function. In this PR we move the shape settings in to the _infer_shape function after we are sure the data has been attached.

@zhengp0 zhengp0 merged commit 1d0146e into main Oct 15, 2024
1 check passed
@zhengp0 zhengp0 deleted the bugfix/ensemble-infer-shape branch October 15, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants