Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
spline
,spline_gpriors
andspline_upriors
arguments toVariableBuilder
class.When
spline
isNone
,VariableBuilder
will generate instance ofVariable
class. Otherwise it will generate instance ofSplineVariable
.When
spline
is notNone
, user can also pass inspline_gpriors
andspline_upriors
as the configuration forSplineGaussianPrior
andSplineUniformPrior
.Configuration
This feature can greatly reduce the complexity of the configuration file when working with splines.
Before, we need to manually create spline bases and use them as if they are independent covariates. We will need to pre-know how many spline bases there are to create the configuration file.
And now with this feature, we don't have to create the spline bases outside of
spxmod
, it will generate the design matrix with in theencode
function and therefore greatly reduce the configuration complexityAnd we allow to add priors to regularize each spline define within the
space
.Miscellaneous
SparseParameter
as the child ofregmod.parameter.Parameter
to collect the sparse prior matrix.__init__
function ofSparseRegmodModel
to automatically parse the dictionary input, but assume all models to only have one parameter which Gaussian, Binomial and Poisson models are.