Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find thumbnail [restore scan for .webp, .jpg, .png or .gif to support Vimeo etc — not just .webp thumbnails as provided by yt-dlp from YouTube!] #163

Merged
merged 1 commit into from
May 29, 2024

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented May 28, 2024

This PR adjusts the thumbnail fetching mechanism based on the assumption its location is inside the video directory.

@deldesir deldesir added the bug Something isn't working label May 28, 2024
@deldesir deldesir requested a review from holta May 28, 2024 20:02
@deldesir deldesir self-assigned this May 28, 2024
@deldesir
Copy link
Collaborator Author

Vimeo thumbnails are jpg, we no longer support webp files only

@holta
Copy link
Member

holta commented May 28, 2024

Looks great:

Let's test & merge as soon as PR chapmanjacobd/library#38 or similar is ready!

CLARIF: This PR reverts & tightens up...

@holta holta changed the title Find thumbnail Find thumbnail [restore scan for .webp, .jpg, .png or .gif to support Vimeo etc — not just .webp thumbnails as provided by yt-dlp from YouTube!] May 28, 2024
@holta
Copy link
Member

holta commented May 29, 2024

Awaiting a new version of xklb that includes this commit:

@holta
Copy link
Member

holta commented May 29, 2024

Awaiting a new version of xklb that includes this commit:

CORRECTION!

This PR was tested to work on 10.8.0.62 (Ubuntu 24.10) thanks to:

...as discussed on:

@holta
Copy link
Member

holta commented May 29, 2024

@EMG70 "good news and bad news" progress report!

@EMG70
Copy link

EMG70 commented May 29, 2024

Noted,will await your instructions to test later.

@holta
Copy link
Member

holta commented May 29, 2024

Noted,will await your instructions to test later.

Three PRs were just merged (PR140, PR162, PR163) — that's 99 PR's in total, that are now merged or closed. 🌱

@deldesir should confirm ASAP which/other PRs are "rock solid" / tested / ready:

https://github.com/iiab/calibre-web/pulls

@holta
Copy link
Member

holta commented May 30, 2024

Docs revised accordingly:

@deldesir deldesir deleted the deldesir-patch-32 branch July 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants