Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add industry material demands #4

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

macflo8
Copy link

@macflo8 macflo8 commented Dec 18, 2024

No description provided.

@macflo8
Copy link
Author

macflo8 commented Dec 19, 2024

@danielhuppmann please review 🙏🏻

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some suggestions below to make sure that this will be compatible with common-definitions.

definitions/variable/industry/tag_demand_sectors.yaml Outdated Show resolved Hide resolved
definitions/variable/industry/demand.yaml Outdated Show resolved Hide resolved
definitions/variable/industry/tag_demand_sectors.yaml Outdated Show resolved Hide resolved
definitions/variable/industry/tag_demand_sectors.yaml Outdated Show resolved Hide resolved
@macflo8 macflo8 marked this pull request as ready for review December 19, 2024 14:49
@macflo8
Copy link
Author

macflo8 commented Dec 20, 2024

@danielhuppmann Thanks for the suggestions! All of them should be incorporated now. If there are no other remaining issues, this would be ready for merging from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants