Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR extends trigger detection to recognize Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
guibeira
force-pushed
the
fix-async-python
branch
from
bf701bd to
3ae393c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@registry/index.json`:
- Around line 25-33: The registry entries for "iii-lsp" and "image-resize" list
only two supported_targets but the CI builds nine platforms; fix by updating
each worker's supported_targets array to include all 9 platforms built by the
workflow (add the missing target strings to the "supported_targets" arrays in
the entries for iii-lsp and image-resize) or alternatively modify the workflow
to skip building targets not declared in each worker's supported_targets (add
per-worker filtering logic in the build job to consult supported_targets before
queuing platform builds). Ensure references: the "iii-lsp" and "image-resize"
entries and the CI workflow target list are aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 590d40c3-c5b3-4a4d-8bda-f0b3f3418c38
📒 Files selected for processing (3)
iii-lsp/src/analyzer.rsiii-lsp/src/diagnostics.rsregistry/index.json
| "iii-lsp": { | ||
| "type": "binary", | ||
| "description": "III Language Server — autocompletion and hover for III engine functions and triggers", | ||
| "repo": "iii-hq/workers", | ||
| "version": "0.1.0", | ||
| "latest": "latest" | ||
| "tag_prefix": "iii-lsp", | ||
| "supported_targets": ["aarch64-apple-darwin", "x86_64-unknown-linux-gnu"], | ||
| "has_checksum": true, | ||
| "default_config": {}, | ||
| "version": "0.1.0" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import json, re, pathlib
registry_path = pathlib.Path("registry/index.json")
workflow_path = pathlib.Path(".github/workflows/_rust-binary.yml")
registry = json.loads(registry_path.read_text())
declared = set(registry["workers"]["iii-lsp"]["supported_targets"])
wf = workflow_path.read_text()
workflow_targets = set(re.findall(r'- target:\s*([A-Za-z0-9._-]+)', wf))
print("Declared iii-lsp targets:", sorted(declared))
print("Workflow matrix targets:", sorted(workflow_targets))
print("In workflow but not declared:", sorted(workflow_targets - declared))
print("Declared but not in workflow:", sorted(declared - workflow_targets))
PYRepository: iii-hq/workers
Length of output: 660
🏁 Script executed:
cat .github/workflows/_rust-binary.yml | head -150Repository: iii-hq/workers
Length of output: 4683
🏁 Script executed:
# Check if there are per-worker filters or configurations in the workflow
rg -A 5 -B 5 "iii-lsp" .github/workflows/Repository: iii-hq/workers
Length of output: 2652
🏁 Script executed:
# Check other workers for similar patterns
python3 << 'PY'
import json
with open("registry/index.json") as f:
registry = json.load(f)
workers = registry.get("workers", {})
for worker_name, config in sorted(workers.items()):
targets = config.get("supported_targets", [])
print(f"{worker_name}: {len(targets)} target(s) - {targets[:2]}{'...' if len(targets) > 2 else ''}")
PYRepository: iii-hq/workers
Length of output: 281
Registry under-declares supported targets for binary workers
The registry declares only 2 supported_targets for iii-lsp (aarch64-apple-darwin, x86_64-unknown-linux-gnu), but .github/workflows/_rust-binary.yml builds for 9 targets without per-worker filtering. This also affects image-resize, which has the same 2 declared targets despite the workflow building all 9. The mismatch creates inconsistency: either the registry needs to include all 9 targets, or the workflow must be configured to skip undeclared platforms.
Update registry entries or add workflow logic to align declared and built targets.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@registry/index.json` around lines 25 - 33, The registry entries for "iii-lsp"
and "image-resize" list only two supported_targets but the CI builds nine
platforms; fix by updating each worker's supported_targets array to include all
9 platforms built by the workflow (add the missing target strings to the
"supported_targets" arrays in the entries for iii-lsp and image-resize) or
alternatively modify the workflow to skip building targets not declared in each
worker's supported_targets (add per-worker filtering logic in the build job to
consult supported_targets before queuing platform builds). Ensure references:
the "iii-lsp" and "image-resize" entries and the CI workflow target list are
aligned.
1 participant
Summary by CodeRabbit