Skip to content

ci: add release workflows for iii-lsp and vscode extension#20

Merged
guibeira merged 1 commit intomainfrom
ci-for-publish-lsp
Apr 8, 2026
Merged

ci: add release workflows for iii-lsp and vscode extension#20
guibeira merged 1 commit intomainfrom
ci-for-publish-lsp

Conversation

@guibeira
Copy link
Copy Markdown
Collaborator

@guibeira guibeira commented Apr 8, 2026

Summary

  • Add release workflows for iii-lsp binary and iii-lsp-vscode extension (Marketplace + OpenVSX)
  • Add iii-lsp and iii-lsp-vscode to the create-tag workflow
  • Add CI lint job for iii-lsp-vscode (vsce package dry run)
  • Add iii-lsp to the worker registry
  • Use existing GH_APP_ID / GH_APP_PRIVATE_KEY secrets instead of creating new ones
  • Use GITHUB_TOKEN for vscode release workflow (no GitHub App needed)

Test plan

  • CI passes on this branch (vsce package dry run)
  • Trigger iii-lsp-vscode release with a dry-run tag
  • Trigger iii-lsp release with a dry-run tag

Summary by CodeRabbit

  • Chores
    • Streamlined the release workflow by simplifying authentication configuration for CI/CD processes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 115b1d9e-b92c-4787-bb7b-5dccb33e52bf

📥 Commits

Reviewing files that changed from the base of the PR and between 0f8acbd and cc579c8.

📒 Files selected for processing (1)
  • .github/workflows/release-vscode.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/release-vscode.yml

📝 Walkthrough

Walkthrough

The PR removes GitHub App token generation from the release workflow and eliminates its downstream uses. actions/checkout@v4 and softprops/action-gh-release@v2 now use their default authentication instead of explicit token configuration.

Changes

Cohort / File(s) Summary
Workflow Token Configuration
.github/workflows/release-vscode.yml
Removed the Generate token step using actions/create-github-app-token@v2 and eliminated all downstream token references, shifting checkout and release actions to default authentication behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Token gone, workflow flows,
Default paths the action knows,
Simpler auth, cleaner way,
Release runs bright today! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title references adding release workflows, but the actual changeset only removes a token generation step from an existing workflow without adding new workflows. Update the title to accurately reflect the change, such as 'ci: simplify release workflow authentication by removing GitHub App token generation'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-for-publish-lsp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@guibeira guibeira merged commit ec678bf into main Apr 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant