-
Notifications
You must be signed in to change notification settings - Fork 0
Auto-install iii-lsp binary in VS Code extension #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0ad22fc
chore: add iii-lsp-vscode container workflow
guibeira e107919
test: cover iii-lsp release asset selection
guibeira 1bf6ecf
fix: align iii-lsp installer helper api
guibeira 48abd7e
feat: install iii-lsp binary from release
guibeira 26c0159
fix: validate installed iii-lsp paths
guibeira d695b2c
feat: resolve iii-lsp binary during activation
guibeira fb033ec
ci: test iii-lsp-vscode before packaging
guibeira 6bc2c7a
docs: describe automatic iii-lsp install
guibeira 8089e8c
docs: clarify iii-lsp install fallback
guibeira 77dbe4f
docs: add Cursor smoke test instructions
guibeira 782cab4
chore: add iii-lsp-vscode build makefile
guibeira c2cbff3
docs: add iii-lsp demo gif
guibeira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # iii-lsp-vscode Agent Notes | ||
|
|
||
| Use containers for Node commands. Do not install host-global Node packages. | ||
|
|
||
| ```bash | ||
| cd iii-lsp-vscode | ||
| docker build -t iii-lsp-vscode-dev . | ||
| docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/workspace" -w /workspace iii-lsp-vscode-dev npm ci | ||
| docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/workspace" -w /workspace iii-lsp-vscode-dev npm test | ||
| docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/workspace" -w /workspace iii-lsp-vscode-dev npm run package:check | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| FROM node:20-bookworm | ||
|
|
||
| WORKDIR /workspace | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| .PHONY: image install test package-check build install-cursor clean | ||
|
|
||
| IMAGE ?= iii-lsp-vscode-dev | ||
| VSIX ?= iii-lsp.vsix | ||
| NPM_CACHE ?= /tmp/npm-cache | ||
|
|
||
| DOCKER_RUN = docker run --rm -u "$$(id -u):$$(id -g)" -e npm_config_cache=$(NPM_CACHE) -v "$(CURDIR):/workspace" -w /workspace $(IMAGE) | ||
|
|
||
| image: | ||
| docker build -t $(IMAGE) . | ||
|
|
||
| install: image | ||
| $(DOCKER_RUN) npm ci | ||
|
|
||
| test: image | ||
| $(DOCKER_RUN) npm test | ||
|
|
||
| package-check: image | ||
| $(DOCKER_RUN) npm run package:check | ||
|
Comment on lines
+15
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Line 15-Line 19 don’t ensure dependencies are installed before running npm commands. 🔧 Proposed fix-test: image
+test: install
$(DOCKER_RUN) npm test
-package-check: image
+package-check: install
$(DOCKER_RUN) npm run package:check🤖 Prompt for AI Agents |
||
|
|
||
| build: image | ||
| $(DOCKER_RUN) npm ci | ||
| $(DOCKER_RUN) npx vsce package --out $(VSIX) | ||
|
|
||
| install-cursor: build | ||
| cursor --install-extension $(VSIX) --force | ||
|
|
||
| clean: | ||
| rm -f $(VSIX) iii-lsp-cursor.vsix iii-lsp-smoke.vsix tmp.vsix | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: iii-hq/workers
Length of output: 40
Add a non-root default user.
The Dockerfile currently defaults to the root user. Add a
USERdirective to run containers as a non-root user by default.Proposed fix
FROM node:20-bookworm WORKDIR /workspace +USER node📝 Committable suggestion
🧰 Tools
🪛 Trivy (0.69.3)
[error] 1-1: Image user should not be 'root'
Specify at least 1 USER command in Dockerfile with non-root user as argument
Rule: DS-0002
Learn more
(IaC/Dockerfile)
🤖 Prompt for AI Agents