Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height/Width/Duration Validator POC #169

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

digitaldogsbody
Copy link
Member

@digitaldogsbody digitaldogsbody commented Mar 10, 2023

Proof of concept for #144

Still to do, pending discussion in #170:

  • Convert to skeleton modifier script instance
  • Apply to other places that have H/W/D
    • This could possibly be more efficient by being applied to the Class metaclass that all HWD-havers inherit from.
    • Make use of https://docs.pydantic.dev/usage/validators/#field-checks
    • nb: would have to re-add the if 'height'' in values etc code that was removed, as this would no longer be always True (other Class inheritors do not have those fields
  • Regenerate skeleton
  • Open tickets for:
    • Updating existing tests
    • Updating existing recipes
    • Updating make_canvas_from_iiif helper

@digitaldogsbody digitaldogsbody marked this pull request as draft March 10, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant