Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "resizeLeftRight" cursor when able to resize the playlist sidebar, expand activation width #4472

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

svobs
Copy link
Contributor

@svobs svobs commented Jun 27, 2023


Description:

Screen.Recording.2023-06-26.at.23.29.18.mov

Makes resizing the width of the Playlist sidebar easier & more intuitive:

  1. Change cursor to NSCursor.resizeLeftRight when hovering inside the resize activation rect.
  2. Expand width of the activation rect from 4 pts to 10 pts.

@low-batt low-batt self-requested a review July 25, 2023 18:16
Copy link
Contributor

@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to rebase this with develop to get the CI build to work.

When I tried it the cursor changed to the resize cursor at the edge of the playlist. I then moved the cursor to the left. The playlist did not change size. I ended up with a resize cursor in the middle of the window.

As can be seen in the Human Interface Guidelines here there are 3 different resize cursors. Experiments with the Dictionary app and resizing its side panel I see it switching between resizeLeftRight and resizeRight or resizeLeft once a maximum or minimum size has been reached. Testing with Preview I saw this same behavior with its side panel.

I think IINA needs to match the behavior of the Apple applications and switch between the 3 cursors different resize cursors.

@svobs
Copy link
Contributor Author

svobs commented Jul 26, 2023

As can be seen in the Human Interface Guidelines here there are 3 different resize cursors.

Well that's fun. Somehow I never noticed when that feature appeared.

A bit burnt out on these tweaks at the moment and have lots of non-IINA-related work piled up, but will get back to this soon.

@low-batt
Copy link
Contributor

The new commit has to do with miniturizing the Music Mode window…

…f playlist sidebar, to indicate when sidebar can be resized. Expand activation radius for playlist resize from 4 pts to 10 pts so it is easier to resize.
@svobs
Copy link
Contributor Author

svobs commented Jul 26, 2023

The new commit has to do with miniturizing the Music Mode window…

Sorry. Forgot I committed to develop before I branched for that one, instead of the other way around. Didn't back it out and ended up rebasing with that commit. WIll avoid that problem in the future by rebasing directly from origin/develop...

Fixed the rebase. Still need to fix the cursor though.

@svobs svobs marked this pull request as draft July 26, 2023 19:40
@low-batt low-batt linked an issue Apr 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make playlist resizeable (change width)
2 participants