Add live updating of [pause, resume, seek] OSD views while displayed to keep their displayed time up to date #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svobs
changed the title
1 task
svobs
force-pushed
the
pr-osd-live-update
branch
from
8a1ee4d
to
900895b
Compare
|
Squashed and rebased. Can't remember why I put it in Draft status, so reopening. Also improved the title to be more descriptive. |
svobs
changed the title
svobs
changed the title
svobs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently when the OSD is displayed for certain events like play seek, it shows the play time indicator but doesn't update it once displayed, so that it falls out of sync with the OSC and the play time as it changes. This PR hooks into the existing
syncUImechanism so that the OSD continues to be updated while it is displayed.This PR builds on PR #4544 and should be examined/merged after that. Filing this now while it's still fresh in mind.
Oddly I couldn't find an open request for this feature - guess it's not that important 馃