Add Settings checkbox to disable EOF restart (addresses #3785)

[svobs]

• I have read CONTRIBUTING.md
• This implements/fixes issue Starting in 1.3.0, pressing Play (spacebar) while at the end of a video file starts playing the file again from the beginning #3785.

---

Description:

NOTE: If testing this, do not use key bindings! Use either the Playback menu or the Play button in the OSC. There are currently a couple of open bugs which are causing this key binding to be unreliable.

Trying to push this along. Not in love with the text, but would love suggestions.

Also encountered an issue with the Play button. Because it's implemented as a Cocoa toggle button with 2 states, clicking on it will always toggle the icon. Couldn't find an easy way to tell it not to toggle, which presented a problem when at the end and the Play button does nothing. Added a quick & dirty fix by adding code to the syncUI mechanism to bring it back in sync with the actual play state, but there may be numerous other ways to do it and seemed like that could be a whole issue by itself.

[low-batt]

I too am struggling with a name for this setting. As there are multiple ways to restart playback I would go generic and avoid using controls names such as "play" and "resume". Also, possibly we can rely upon the context of being a sub-option of Keep window open after playback finishes. Maybe: Restarting playback seeks to the beginning? I'm not entirely happy with that.

On this:

Because it's implemented as a Cocoa toggle button with 2 states, clicking on it will always toggle the icon. Couldn't find an easy way to tell it not to toggle, which presented a problem when at the end and the Play button does nothing.

The correct solution is to disable the button once EOF is reached if the user has turned off the setting to restart from the beginning. This also means the Resume menu item should be disabled. With the feature of automatically restarting from the beginning disabled you can't start playback while at EOF. The Apple way to indicate controls and menu items are not applicable is to disable them. If the user changes the playback position then these controls would be enabled again.

With this PR not addressing the issues with the spacebar, which is what issue #3785 is reporting we can't say this PR fixes that issue. I'm thinking this needs to be put in draft mode until the key binding problems are sorted out. IINA is too far behind on reviewing and merging. I will see if I can get the attention of the other developers.

[svobs]

The correct solution is to disable the button once EOF is reached if the user has turned off the setting to restart from the beginning. This also means the Resume menu item should be disabled. With the feature of automatically restarting from the beginning disabled you can't start playback while at EOF. The Apple way to indicate controls and menu items are not applicable is to disable them.

Yeah, definitely a rabbit hole of its own...

So I actually attempted this, and it's harder than it seems. We can't generalize that the play button should be disabled at EOF, because it may still be legitimate to play the next item in the playlist. Or loop back from the beginning of the playlist. Or something else. It will require careful consideration of all the possibilities so that we don't risk introducing a new bug where it worked fine before.

Also, what about the Playback > Resume menu item? And what about the Next and Prev buttons? I would think they should match the behavior of the Play button too.

Considering the effort that would go into that, let's not have perfect be the enemy of the good? It's a pretty minor issue to worry about, considering it's blocking a fix which multiple users have expressed interest in getting resolved.

Maybe: Restarting playback seeks to the beginning? I'm not entirely happy with that.

That could work. Will continue to ponder...

I'm thinking this needs to be put in draft mode until the key binding problems are sorted out

Looks like that should happen soon, but I'll put in draft for now as per request.

[low-batt]

Thanks for putting this into draft mode. I hope the devs will find some time for reviewing and merging soon.

Also, what about the Playback > Resume menu item?

I mentioned that in my comment. Yes, that menu item also needs to be disabled. I don't think the next and prev operations are tied to this.

Disabling is definitely the correct way to handle this. It is not a case of disabling at EOF. It is disabling only when pressing space does not start playback. Exactly the same conditions the code already has to check.