Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to repeat file/playlist when opening a media #4761

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

uiryuu
Copy link
Member

@uiryuu uiryuu commented Jan 8, 2024


Description:
Added an new option:

image

Wording suggestions are welcomed

@low-batt
Copy link
Contributor

low-batt commented Jan 9, 2024

This comment on issue #2139 says:

If possible, maybe have two settings - one for music playback and one for video, as I'd rather my videos didn't loop by default.

We don't have a concept of separate settings for music mode, but we already have precedent for a Only in "music mode" setting as can be seen in the screenshot above. Maybe this new setting needs such a subordinate setting as well.

Doesn't the new text need to be added under en.lproj as well?

@@ -525,22 +524,57 @@
<binding destination="IBP-Mz-Maa" name="value" keyPath="values.playlistShowMetadataInMusicMode" id="nxW-hX-9co"/>
</connections>
</button>
<button verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="AbF-Dw-gXa">
<rect key="frame" x="118" y="7" width="260" height="18"/>
<buttonCell key="cell" type="check" title="Enable repeat automatically upon start" bezelStyle="regularSquare" imagePosition="left" state="on" inset="2" id="j4o-RP-pfA">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a colon after "start". I looked over the settings and that is a consistent convention, except for one other setting, Check for updates is also missing a colon at the end of the label.

@svobs
Copy link
Contributor

svobs commented Jan 17, 2024

Wording suggestions are welcomed

How about Enable repeat for new windows: ? Because using "start" isn't clear whether "start" means "start of playback" or "application start".

Assuming this is for new windows. Is it also set for existing windows when opening a media in an existing window? If so it would have to be something like Enable repeat when media is opened manually, following the existing terminology in Settings > UI > Window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants