-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes & improvements to Subtitle Chooser #4833
base: develop
Are you sure you want to change the base?
Conversation
164f8da
to
424445f
Compare
424445f
to
2ed938a
Compare
This commit will: • Break osd.sub_found into osd.sub_found and osd.sub_downloading, for more appropriately specific messages • In SubChooseView: fix table border bezel, increase font size slightly & set preferred width to 600 • Modify OpenSubtitles row details: add release year, remove rating, set max 2 fraction digits to fps, remove time from upload date, increase spacing to make attribute separation more clear
2ed938a
to
f08cb2a
Compare
Squashed + rebased to fix merge errors + improved commit msg. |
@@ -83,7 +83,8 @@ | |||
"osd.find_online_sub" = "Finding online subtitles…"; | |||
"osd.find_online_sub.source" = "from"; | |||
"osd.sub_not_found" = "No subtitles found"; | |||
"osd.sub_found" = "%d subtitles found. Downloading…"; | |||
"osd.sub_found" = "%d subtitles found."; | |||
"osd.sub_downloading" = "Downloading %d subtitles"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add this to en.lproj.
@@ -290,6 +299,12 @@ extension FloatingPoint { | |||
return self | |||
} | |||
} | |||
|
|||
/// Formats as String, rounding the number to 2 digits after the decimal | |||
var stringMaxFrac2: String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using a name like stringWithMaxFractionDigit2
for better readability.
@@ -69,6 +69,7 @@ enum OSDMessage { | |||
|
|||
case startFindingSub(String) // sub source | |||
case foundSub(Int) | |||
case downloadingSub(Int, String) // download count, ssub source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sub
Description:
Like #4825 but makes additional changes:
osd.sub_found
, previously set to%d subtitles found. Downloading…
, was not exactly appropriate as the heading for the list of subtitles to download. It looks like this was done because it was used both for the subtitle list & for the actual "downloading" message. So I changed the existingosd.sub_found
message to remove theDownloading…
part, added a newosd.sub_downloading
message whose English version isDownloading %d subtitles
, and changed the "downloading" message to use this key instead.fps
attribute's displayed value.