Remove unsupported codecs from hwdec-codecs #4942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased with |
This commit will: - Add a new class HardwareDecodeCapabilities - Add a call to HardwareDecodeCapabilities.checkCapabilities in AppDelegate.applicationWillFinishLaunching - Add a new method userOptionsContains to MPVController that checks if a user has configured a mpv option in IINA's advanced settings - Add a new property mpvCodecToCodecTypes to MPVController that maps a mpv codec name to core media video codec types - Add a new adjustCodecWhiteList method to MPVController that removes codecs from the mpv hwdec-codecs option if the Mac does not support hardware decoding for that codec - Change the applyHardwareAccelerationWorkaround method to use the value of the hwdec-codecs option instead of a hardcoded value These changes cause mpv to not attempt to use hardware decoding for a codec that is known to not be supported. This eliminates the overhead of setting up for hardware decoding only to have it fail. This is not comprehensive. This only covers the recent codecs whose support for hardware decoding varies among Macs. This merely reduces the dependence upon the FFmpeg fallback to software decoding feature in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
HardwareDecodeCapabilitiesHardwareDecodeCapabilities.checkCapabilitiesinAppDelegate.applicationWillFinishLaunchinguserOptionsContainstoMPVControllerthat checks if a user has configured ampvoption in IINA's advanced settingsmpvCodecToCodecTypestoMPVControllerthat maps ampvcodec name to core media video codec typesadjustCodecWhiteListmethod toMPVControllerthat removes codecs from thempvhwdec-codecsoption if the Mac does not support hardware decoding for that codecapplyHardwareAccelerationWorkaroundmethod to use the value of thehwdec-codecsoption instead of a hardcoded valueThese changes cause mpv to not attempt to use hardware decoding for a codec that is known to not be supported. This eliminates the overhead of setting up for hardware decoding only to have it fail. This is not comprehensive. This only covers the recent codecs whose support for hardware decoding varies among Macs. This merely reduces the dependence upon the FFmpeg fallback to software decoding feature in some cases.
Description: