Remove code for supporting older systems #4977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low-batt
approved these changes
Jun 7, 2024
| @@ -1127,11 +1125,11 @@ | |||
| <point key="canvasLocation" x="14" y="-292"/> | |||
| </customView> | |||
| <customView id="1fz-oP-RhZ" userLabel="Prefs > UI > PIP"> | |||
| <rect key="frame" x="0.0" y="0.0" width="480" height="124"/> | |||
| <rect key="frame" x="0.0" y="-14" width="480" height="138"/> | |||
There was a problem hiding this comment.
I guess Xcode makes odd changes like setting y to negative values due to constraints not being quite right? We have quite a few problems in the XIBs that should be fixed at some point.
| mainView.layer?.backgroundColor = CGColor(gray: 0.1, alpha: 1) | ||
| visualEffectView.material = .ultraDark | ||
| window.appearance = NSAppearance(iinaTheme: theme) | ||
| if #available(macOS 10.16, *) { |
There was a problem hiding this comment.
I recall something about needing to retain #available referencing 10.16 instead of 11 due to the need to support old SDKs. We might want to consider cutting off support for older Xcode versions, updating this, and allow use of the latest Swift features. But first we should merge a lot of the outstanding PRs before doing refactoring that can introduce merge conflicts.
|
I may need to pull my approval. Hang on… |
|
I confirmed what I found is a regresison in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove code previously used for 10.11 - 10.14 systems. The major ones include a lot of colors, appearance, PIP and touchbar support.