Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update watch-later-options workaround for mpv 0.38.0 #5019

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

low-batt
Copy link
Contributor

This commit will:

  • Add a new method userOptionsContains to MPVController
  • Remove the workaround from mpvInit for secondary-sub-visibility missing from watch-later-options
  • Add a workaround to mpvInit for secondary-sid and secondary-sub-delay missing from watch-later-options
  • Add sorting of the logged watch-later-options value

The problem in mpv with secondary-sub-visibility missing from watch-later-options has been fixed with the upgrade to mpv 0.38.0. However secondary-sid and secondary-sub-delay are missing from watch-later-options in mpv 0.38.0 (mpv issue mpv-player/mpv#14417). This commit updates the workaround for 0.38.0. Issue #14417 has been fixed in mpv, so the next time mpv is upgraded this workaround can finally be removed.


Description:

This commit will:
- Add a new method userOptionsContains to MPVController
- Remove the workaround from mpvInit for secondary-sub-visibility
  missing from watch-later-options
- Add a workaround to mpvInit for secondary-sid and secondary-sub-delay
  missing from watch-later-options
- Add sorting of the logged watch-later-options value

The problem in mpv with secondary-sub-visibility missing from
watch-later-options has been fixed with the upgrade to mpv 0.38.0.
However secondary-sid and secondary-sub-delay are missing from
watch-later-options in mpv 0.38.0 (mpv issue #14417). This commit
updates the workaround for 0.38.0. Issue #14417 has been fixed in mpv,
so the next time mpv is upgraded this workaround can finally be removed.
@low-batt
Copy link
Contributor Author

The log messages look like:

22:37:48.778 [mpv0][d] Adding secondary-sid to watch-later-options
22:37:48.778 [mpv0][d] Adding secondary-sub-delay to watch-later-options
22:37:48.778 [mpv0][d] Options mpv is configured to save in watch later files: ab-loop-a,ab-loop-b,af,aid,audio-delay,brightness,contrast,deinterlace,edition,gamma,hue,mute,panscan,saturation,secondary-sid,secondary-sub-ass-override,secondary-sub-delay,secondary-sub-pos,secondary-sub-visibility,sid,speed,start,sub-ass-force-margins,sub-ass-override,sub-ass-vsfilter-aspect-compat,sub-delay,sub-pos,sub-scale,sub-speed,sub-use-margins,sub-visibility,vf,vid,video-align-x,video-align-y,video-aspect-method,video-aspect-override,video-crop,video-pan-x,video-pan-y,video-rotate,video-scale-x,video-scale-y,video-unscaled,video-zoom,volume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant