Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main.js #1253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update main.js #1253

wants to merge 1 commit into from

Conversation

blambin
Copy link

@blambin blambin commented Dec 22, 2017

fix error loading on abave firefox 57

@blambin
Update main.js
f73f811 
fix error loading on abave firefox 57
McBen
McBen suggested changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@McBen McBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on TM/Chrome
"unsafeWindow is not defined"

@McBen
Copy link
Contributor

McBen commented Dec 22, 2017

this leads again to something like:
window.PLAYER = window.PLAYER || (unsafeWindow && unsafeWindow.PLAYER)

which is nearly the same as #1249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McBen McBen McBen requested changes

@tixomirx tixomirx tixomirx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blambin @McBen @tixomirx