Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating IITC Mobile to SDK 28, fixed issues with new intel URL #1286

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mike-lambert
Copy link

A bulk upgrade of "gradle" branch.

  • Eliminated "test build" flavor
  • Migrated to build-tools 28 with compatibility 4.0 - 9.0 (tested on 6.0.1, 7.0, 9.0)
  • Added runtime permissions request for location plugin
  • Apache HTTP Client replaced by OkHttpClient
  • Externalized signing configuration
  • Merged recent master
  • Reviewed intel URLs in plugins

@ghost
Copy link

ghost commented Nov 3, 2018

When building mobile using this change I get the following error

> Configure project :iitcm
Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error.


FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Users\xxxx\AndroidStudioProjects\mike-iitc-mobile\mobile\iitcm\build.gradle' line: 5

* What went wrong:
A problem occurred evaluating project ':iitcm'.
> C:\Users\xxxx\AndroidStudioProjects\mike-iitc-mobile\mobile\signing.properties (The system cannot find the file specified)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 37s

@mike-lambert
Copy link
Author

mike-lambert commented Nov 3, 2018

@hedwin moved signing properties to root buildscript and removed signing config for debug

@gusowski1
Copy link
Contributor

When running the python buildscript i get the following error:
Der Befehl "ant" ist entweder falsch geschrieben oder konnte nicht gefunden werden.
Error: mobile app failed to build. ant returned 1

The python part is still trying to build an ant app.

Furthermore if I open the iitc root folder as project android studio notice that in /mobile is still an ant app and recommends the migration to grandle

If i open the iitcm project in android studio the build could be finished, but that seems only be part of the hole iitcm app

modos189 added a commit to IITC-CE/ingress-intel-total-conversion that referenced this pull request Nov 22, 2018
* Added runtime permissions request for location plugin
* Apache HTTP Client replaced by OkHttpClient

used developments iitc-project/ingress-intel-total-conversion#1286
#2
@mike-lambert
Copy link
Author

@modos189 please be noted that there one more commit, which integrates gradle-based IITC Mobile build into existing IITC build system seamlessly.

@modos189
Copy link

Added storage read permissions
Added new intel url handling in manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants